Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testing bug and clippy lints #144

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Conversation

jmfrank63
Copy link

This PR fixes Clippy complaining with 1.6.2 version of Rust and moves the timestamp creation for multiple tests after the instantiation of the Rate Limiter.

Copy link
Collaborator

@antifuchs antifuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but can you run stable rustfmt on your submission (cargo fmt should do it)?

Happy to merge once the test passes (:

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #144 (863e5b6) into master (5d04b8a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   97.54%   97.49%   -0.05%     
==========================================
  Files          30       30              
  Lines        2197     2195       -2     
==========================================
- Hits         2143     2140       -3     
- Misses         54       55       +1     
Impacted Files Coverage Δ
governor/tests/middleware.rs 100.00% <ø> (ø)
governor/src/clock.rs 93.22% <100.00%> (ø)
governor/src/clock/quanta.rs 98.33% <100.00%> (-1.67%) ⬇️
governor/src/errors.rs 100.00% <100.00%> (ø)
governor/src/gcra.rs 100.00% <100.00%> (ø)
governor/src/jitter.rs 100.00% <100.00%> (ø)
governor/src/middleware.rs 100.00% <100.00%> (ø)
governor/src/state.rs 100.00% <100.00%> (ø)
governor/src/state/direct/future.rs 100.00% <100.00%> (ø)
governor/src/state/in_memory.rs 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@antifuchs
Copy link
Collaborator

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 19, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants