Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get from extension #16

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Get from extension #16

merged 2 commits into from
Jul 17, 2020

Conversation

ririsoft
Copy link
Contributor

This PR adds some get_from_* utilities I have been missing from Infer: checking the extension corresponding to a given mime type string and getting the mime type from a file extension without file system access.

@ririsoft
Copy link
Contributor Author

I will rebase once #17 is merged

Copy link
Collaborator

@paolobarbolini paolobarbolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bojand
Copy link
Owner

bojand commented Jul 17, 2020

👍
I'll let you and @paolobarbolini run with the PRs and changes.
I am pretty swamped today and most of the weekend (but have access to internet + computer); I have added @paolobarbolini as a collaborator so he should be able to merge and tag.
Please make sure to update the crate version in Cargo.toml before tagging a release.
To do a release once everything is ready just tag the release and push the tag, the GitHub actions should handle the rest. Sometimes the git-chglog portion doesn't seem to generate the changelog (no commits) within the action but you can manually create release notes if there are issues.
Feel free to tag me in an issue and I can respond / unblock as promptly as possible.
Thanks for all the changes this is super cool!

@paolobarbolini paolobarbolini merged commit 3c9365f into bojand:master Jul 17, 2020
@ririsoft ririsoft deleted the get-from-ext branch July 19, 2020 13:34
@ririsoft ririsoft mentioned this pull request Jul 20, 2020
@paolobarbolini paolobarbolini mentioned this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants