Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleaker Sliders #10081

Open
bryevdv opened this issue May 28, 2020 · 4 comments · May be fixed by #13551
Open

Sleaker Sliders #10081

bryevdv opened this issue May 28, 2020 · 4 comments · May be fixed by #13551

Comments

@bryevdv
Copy link
Member

bryevdv commented May 28, 2020

Our sliders seem really overly large and clunky to me. I feel like even a minor tweek could make them substantially more attractive. Below is before/after with some small experimentation in the browser CSS editor:

Screen Shot 2020-05-27 at 5 40 41 PM

Screen Shot 2020-05-27 at 5 40 18 PM

Thoughts @bokeh/dev ? @mattpap are there any special considerations to changes like this? AFAIK the CSS changes like this do not/should not affect the layout at all.

@bryevdv bryevdv added this to the 2.1 milestone May 28, 2020
@pavithraes
Copy link
Member

I like the slimmer sliders. :)

@mattpap
Copy link
Contributor

mattpap commented May 28, 2020

are there any special considerations to changes like this?

Not really. Layout will adapt to CSS changes. Just make sure you follow how handle dimensions and position are computed, because it's easy to break the slider.

@howdoyouworkthis
Copy link

Slimmer is good. I have some other suggestions to fall in line with modern trendy material design - making the radii consistent between the slider bar and the handle, using related colors (or even gradients), or dropping the drop shadows. You could even then the bars out to just a line. :)

@bryevdv bryevdv modified the milestones: 2.1, future Jun 5, 2020
@bryevdv
Copy link
Member Author

bryevdv commented Jun 5, 2020

I'm moving this out to future because I'd like to make a whole, concerted effort to overhaul the visual style of all of our built-in widgets as well as our plot defaults, together (rather than ad-hoc one by one). But that's really 3.0 territory (but we should start trying to plan for it sooner, rather than later)

FWIW previous version did just have a single line for the slider. I know some users definitely make use of the feature to change the bar color, but maybe that could be used for a line as well (and line thickness also made adjustable)

@bryevdv bryevdv modified the milestones: 3.0, 3.x Jun 22, 2022
@mattpap mattpap linked a pull request Nov 26, 2023 that will close this issue
10 tasks
@mattpap mattpap modified the milestones: 3.x, 3.4 Nov 26, 2023
@mattpap mattpap modified the milestones: 3.4, 3.5 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants