New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Legend
item fill policies
#12701
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.1 #12701 +/- ##
===========================================
Coverage 92.23% 92.23%
===========================================
Files 314 314
Lines 19682 19687 +5
===========================================
+ Hits 18154 18159 +5
Misses 1528 1528 |
This looks great. Thank you @mattpap. |
ca0c1c1
to
9ddbd19
Compare
9ddbd19
to
b872bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first two comments are suggestions/advisory but I do want to get discussion and agreement regarding any changes to defaults.
@mattpap I think this PR is very close, would you like me to finish off the three suggestions above so that it can be merged while you focus on other PRs? |
43f46dd
to
659343f
Compare
659343f
to
481787d
Compare
Examples' test failure is unrelated and fixed in PR #12754. |
This adds rudimentary support for item fill policies:
fixes #12692
/cc @mosc9575