Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify default value for FactorRange.{start,end} #12747

Open
mattpap opened this issue Jan 17, 2023 · 0 comments
Open

Don't specify default value for FactorRange.{start,end} #12747

mattpap opened this issue Jan 17, 2023 · 0 comments

Comments

@mattpap
Copy link
Contributor

mattpap commented Jan 17, 2023

Prior to PR #12565 all readonly properties had an intrinsic default value, which usually doesn't make sense. So now they don't except for this, because FactorRange in bokehjs sets start and end during model initialization, which always results in 0, because that happens before sensible values can be computed. Due to how defaults' testing works, this requires setting the default value in bokeh. Ultimately this default will be removed, which will require changes to FactorRange's initialization, which I don't want to get into here.

Originally posted by @mattpap in #12565 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant