Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace utcnow and utcfromtimestamp function calls #13125

Closed
ianthomas23 opened this issue May 11, 2023 · 5 comments · Fixed by #13147
Closed

Replace utcnow and utcfromtimestamp function calls #13125

ianthomas23 opened this issue May 11, 2023 · 5 comments · Fixed by #13147
Labels
python Issues that should only require updating Python code reso: completed type: task
Milestone
3.3

Comments

@ianthomas23
Copy link
Member

datetime.utcnow and utcfromtimestamp will be deprecated in Python 3.12. We use both in our codebase and should replace them, see python/cpython#103857.
@ianthomas23 ianthomas23 added type: task python Issues that should only require updating Python code labels May 11, 2023
@ianthomas23 ianthomas23 added this to the 3.3 milestone May 11, 2023
@rielAsh24
Copy link
Contributor

rielAsh24 commented May 17, 2023 •
edited
Loading

@ianthomas23 Hi, I'll be looking into this issue

@rielAsh24
Copy link
Contributor

rielAsh24 commented May 18, 2023 •
edited
Loading

@ianthomas23 Hey, I'm facing some difficulty setting-up geckodrivers as stated in the contribution guidelines. pip and conda show the package doesn't exist.

geckodriver install error

Would be glad if guided on the same.

@ianthomas23
Copy link
Member Author

@rielAsh24 I am guessing that you are using an ARM64 mac such as an M1? If so just temporarily comment out the geckodriver line in your environment yaml file as there is no such package available for ARM64 macOS. That should allow you to continue following the developer installation instructions. You won't be able to run the BokehJS integration tests that generate images, but this is OK as you should not need to modify those.

@rielAsh24
Copy link
Contributor

@ianthomas23 Got you, I'll try it right away. Thank you!

@rielAsh24 rielAsh24 mentioned this issue May 20, 2023
Merged
2 tasks
@rielAsh24
Copy link
Contributor

Hey @ianthomas23, I added the required changes to the files and ran all the tests recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Issues that should only require updating Python code reso: completed type: task
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Replaced utcnow and utcfromtimestamp functions rielAsh24/bokeh
3 participants
@mattpap @ianthomas23 @rielAsh24