Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMap example not showing glyphs #13771

Closed
bryevdv opened this issue Mar 19, 2024 · 4 comments · Fixed by #13832
Closed

GMap example not showing glyphs #13771

bryevdv opened this issue Mar 19, 2024 · 4 comments · Fixed by #13832

Comments

@bryevdv
Copy link
Member

bryevdv commented Mar 19, 2024

With 3.4.0 the scatter markers are not appearing on the gmap example:

https://docs.bokeh.org/en/3.4.0/docs/examples/topics/geo/gmap.html

Screenshot 2024-03-19 at 10 57 28
@bryevdv
Copy link
Member Author

bryevdv commented Mar 19, 2024

As a (probably) separate aside, GMaps API also warns:

Google Maps JavaScript API has been loaded directly without loading=async. This can result in suboptimal performance. For best-practice loading patterns please see https://goo.gle/js-api-loading

@hakan-77
Copy link

@bryevdv I can confirm this is still the case with 3.4.1

@bryevdv bryevdv modified the milestones: 3.x, 3.5 Apr 17, 2024
@bryevdv
Copy link
Member Author

bryevdv commented Apr 17, 2024

Triaging for 3.5 but this should ideally be backported to 3.4.x

@mattpap mattpap modified the milestones: 3.5, 3.4.2 Apr 18, 2024
@mattpap
Copy link
Contributor

mattpap commented Apr 18, 2024

This was broken in PR #13554. Projections are applied in secondary glyphs to the original data, leading to invalid coordinates or even NaNs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants