Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs sidebars take up way to much space #13866

Open
bryevdv opened this issue May 5, 2024 · 4 comments
Open

Docs sidebars take up way to much space #13866

bryevdv opened this issue May 5, 2024 · 4 comments

Comments

@bryevdv
Copy link
Member

bryevdv commented May 5, 2024

From the 3.4.1 docs, happens on Safari, Chrome, and FF on OSX

Screenshot 2024-05-05 at 15 49 51

cc @tcmetzger in case you have any quick ideas why the middle section won't grow to fill the space.

@tcmetzger
Copy link
Member

@bryevdv As far as I can see (on my Win11 laptop monitor), the Bokeh docs behave just like the docs of Pydata Sphinx Theme (e.g. https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/layout.html). You could try to adjust the max-width as described in https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/layout.html#horizontal-spacing, I think!

@bryevdv
Copy link
Member Author

bryevdv commented May 5, 2024

I guess this is a recent change on the theme side then, I just really don't like it. Do you have any thoughts on how our docs should look and behave in this regard?

@tcmetzger
Copy link
Member

I personally like the not-too-wide central section - longer lines (fewer line breaks) would make the text generally harder to read. Too many line breaks also aren't helpful, of course, but I think the theme generally strikes a good balance. I don't feel strongly about this, though, and I currently only have my laptop monitor to look at. I don't have objections to increasing the width!

@bryevdv
Copy link
Member Author

bryevdv commented May 5, 2024

I suppose it's a matter of preference, but my take would be that allowing the center to adjust to take up more space affords everyone an option to get what suits them — by adjusting the width of their browser window. Whereas limiting the width means that some people, those who prefer longer lines and more info on a page, have no recourse. I'd prefer the option that gives everyone an way to satisfy their preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants