Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly border in GMapPlot? #4350

Closed
ResidentMario opened this issue May 22, 2016 · 3 comments
Closed

Ugly border in GMapPlot? #4350

ResidentMario opened this issue May 22, 2016 · 3 comments

Comments

@ResidentMario
Copy link

I'm not sure if this is "working as intended", but I daresay from my perspective as a user it isn't. When you create a GMapPlot it creates, along with the map, a huge ugly border, as shown:

screen shot 2016-05-21 at 11 59 57 pm

I can't seem to find a way of removing it (aside from maybe messing with the underlying JS after the file has been generated?).

Is this a library error?

Here's a MWE:

from bokeh.io import output_file, show
from bokeh.models import GMapPlot, GMapOptions, DataRange1d, ColumnDataSource, Circle, PanTool, HoverTool

map_options = GMapOptions(lat=40.7484, lng=-73.9857, map_type = "terrain", zoom=10)

GMap = GMapPlot(x_range = DataRange1d(), y_range = DataRange1d(), map_options = map_options , title = "Eneumerate",
        plot_width=800, plot_height=300)

See also this Stack Overflow question.

@birdsarah
Copy link
Member

Thanks for the report. I am seeing that here too: http://bokeh.pydata.org/en/latest/docs/user_guide/geo.html

But I swear it didn't used to be like that, I wonder if something's changed in the GoogleMaps API.

Thanks for the report.

@birdsarah birdsarah added this to the short-term milestone May 22, 2016
@birdsarah
Copy link
Member

I am also seeing it here: http://nbviewer.jupyter.org/github/bokeh/bokeh-notebooks/blob/master/tutorial/00%20-%20intro.ipynb and I know for sure it wasn't there when I gave this tutorial a few weeks ago.

Must be a GMaps change. Thanks again for the report.

@bryevdv
Copy link
Member

bryevdv commented Jun 7, 2016

I am fairly certain this was caused by the mismatched defaults, and fixed by #4434 just merged. Some of the default that needed fixing up were specifically these. Here is a screenshot from current master:

screen shot 2016-06-07 at 5 15 02 pm

Closing for now. @ResidentMario we should have a dev build you can easily try out in a day or two. Please re-open if you see the issue persist then.

@bryevdv bryevdv closed this as completed Jun 7, 2016
@bryevdv bryevdv modified the milestones: 0.12, short-term Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants