Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use box-sizing: border-box for everything under bk-root #5668

Closed
mattpap opened this issue Jan 7, 2017 · 2 comments
Closed

Use box-sizing: border-box for everything under bk-root #5668

mattpap opened this issue Jan 7, 2017 · 2 comments
Assignees
@mattpap
Labels
reso: completed tag: component: bokehjs tag: layout type: task
Projects
Focus: Layout
Milestone
1.1

Comments

@mattpap
Copy link
Contributor

mattpap commented Jan 7, 2017

Make sure everything works afterwards. Also remove any specific box-sizings, but leave one in data_table.less (SlickGrid requires content box model). Fix this issue after #2933 and #5102.
@mattpap mattpap added this to the 0.12.5 milestone Jan 7, 2017
@mattpap mattpap self-assigned this Jan 7, 2017
@mattpap mattpap mentioned this issue Jan 19, 2017
Closed
@mattpap mattpap modified the milestones: 0.12.6, 0.12.5 Mar 16, 2017
@mattpap mattpap modified the milestones: 0.12.7, 0.12.6 May 18, 2017
@mattpap mattpap added this to Triage in Focus: Layout Jun 27, 2017
@bryevdv bryevdv modified the milestones: 0.12.7, 0.12.8 Aug 23, 2017
@mattpap mattpap moved this from Triage to Implemented in Focus: Layout Aug 25, 2018
@bryevdv bryevdv modified the milestones: 0.13.x, short-term Sep 11, 2018
@mattpap mattpap modified the milestones: short-term, 1.1 Oct 4, 2018
@bryevdv
Copy link
Member

bryevdv commented Feb 3, 2019

@mattpap what is the status of this issue?

@mattpap
Copy link
Contributor Author

mattpap commented Feb 3, 2019

Fixed in PR #8085.

@mattpap mattpap closed this as completed Feb 3, 2019
@mattpap mattpap moved this from Implemented to Done in Focus: Layout Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattpap mattpap

Labels
reso: completed tag: component: bokehjs tag: layout type: task
Projects
Focus: Layout
Done
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Use border-box as the default box model under bk-root bokeh/bokeh
2 participants
@mattpap @bryevdv