Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label for Span #7309

Open
abdelwahed opened this issue Dec 10, 2017 · 4 comments
Open

Adding label for Span #7309

abdelwahed opened this issue Dec 10, 2017 · 4 comments

Comments

@abdelwahed
Copy link

I would like to see the option of adding label to vertical/horizontal "Span"s (the solid and dashed green and red lines in the attached figure)
perhaps
redspan.label = "breathing rate"

screen shot 2017-12-11 at 10 48 19 am

@bryevdv
Copy link
Member

bryevdv commented Dec 13, 2017

Is there a reason existing Label or LabelSet will not work? In general we are in a mode of trying to pare down and simplify things, so if this would duplicate functionality that can be accomplished another way then I'd probably -1 on it.

@mattpap
Copy link
Contributor

mattpap commented Dec 13, 2017

I think the problem is that currently we can't attach an annotation to another annotation, only to canvas, frame and panels. I would like to implement this at some point, as part of layout work.

@abdelwahed
Copy link
Author

abdelwahed commented Dec 14, 2017

@bryevdv A label (with render mode "css") would looks like the figure attached below:

  • can the label be aligned vertically parallel to the corresponding line?
  • for a simple label, having it as a span's property would take less coding (rather than creating Label object)

screen shot 2017-12-14 at 1 50 19 pm

@jasonsross
Copy link
Contributor

vertical and horizontal lines with labels showing up IN the appropriate axis are very common practice in engineering situations. They are know as chart limits or generally "reference" lines. It looks like span already accomplishes the line itself with relative ease, so it would be extremely convenient to specify a label for a span which will by default appear within the axis, not within the plotting area. Since we are already specifying the location for the span, it seems redundant to then specify the location again for the label of the span. Hope you can consider supporting this.

@bryevdv bryevdv modified the milestone: short-term Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants