[FEATURE] Fail on bokeh.embed.file_html invalid template #9195
Comments
|
@unc0mm0n the code actually ends up here: and here {% from macros import embed %}
<!DOCTYPE html>
<html lang="en">
{% block head %}
<head>
{% block inner_head %}
<meta charset="utf-8">
<title>{% block title %}{{ title | e if title else "Bokeh Plot" }}{% endblock %}</title>
{% block preamble %}{% endblock %}
{% block resources %}
{% block css_resources %}
{{ bokeh_css | indent(8) if bokeh_css }}
{% endblock %}
{% block js_resources %}
{{ bokeh_js | indent(8) if bokeh_js }}
{% endblock %}
{% endblock %}
{% block postamble %}{% endblock %}
{% endblock %}
</head>
{% endblock %}
{% block body %}
<body>
{% block inner_body %}
{% block contents %}
{% for doc in docs %}
{{ embed(doc) if doc.elementid }}
{% for root in doc.roots %}
{% block root scoped %}
{{ embed(root) | indent(10) }}
{% endblock %}
{% endfor %}
{% endfor %}
{% endblock %}
{{ plot_script | indent(8) }}
{% endblock %}
</body>
{% endblock %}
</html>So the way to use this is to supply template text that override, e.g. the "contents" block. I agree this is not well documented, so I will leave this issue open for that task. I am not sure what else can be done, though. There's not 100% reliable way to judge if the string that is passed is a filename or not, which risks raising errors or warnings in cases where there should not be one. |
Starting with 2.0, we could use |
|
That sounds good |
Is your feature request related to a problem? Please describe.
Right now bokeh.embed.file_html fails silently if given invalid input (e.g. file string "./template.html") as input parameter and generates with the default bokeh.core.template.FILE template. This leads mostly to confusion.
Describe the solution you'd like
Throw an exception when the parameter for template cannot be used, instead of silently deleting it.
Describe alternatives you've considered
Possibly print a warning message stating that template was swapped to default, or at least support creation of Jinja2 Templates from file name strings
The text was updated successfully, but these errors were encountered: