Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make hover tooltip arrow style configurable #9378

Open
allenfrostline opened this issue Nov 6, 2019 · 4 comments
Open

[FEATURE] Make hover tooltip arrow style configurable #9378

allenfrostline opened this issue Nov 6, 2019 · 4 comments

Comments

@allenfrostline
Copy link

It's actually a very simple one, see image below:

Screen Shot 2019-11-06 at 12 56 15 AM

Instead of the current style, won't it be better looking if we have the grey triangular head colored in white (with some transparency, too) just like the rest of the hovering tooltip? I've been looking for ways to change that color using css etc. but it's definitely better if the coloring can be done from an interface provided by the package.

@bryevdv
Copy link
Member

bryevdv commented Nov 6, 2019

There is no accounting for preferences @allenfrostline I actually would not like the "arrow" to match and in fact would rather it be much darker. But we can definitely consider making it more directly configurable.

@bryevdv bryevdv added this to the short-term milestone Nov 6, 2019
@bryevdv bryevdv changed the title [FEATURE] Hover Tooltip Improvement [FEATURE] Make hover tooltip arrow style configurable Mar 11, 2020
@arefeena
Copy link

Hey, I am new to the project and I would like to take a crack at this.

@bryevdv
Copy link
Member

bryevdv commented Nov 27, 2020

@arefeena We would love to have your contribution. New contributors arrive with a wide variety of experience we can't predict, so please let us know where we can help provide guidance once you start to take a look.

@arefeena
Copy link

arefeena commented Dec 1, 2020

UPDATE: opened PR #10750 so we can discuss specifics there

@bryevdv looks like I got it working on my branch: arefeena/9378_tooltip_arrow_styling

I ran the examples/app/gapminder demo, replacing the existing HoverTool creation (L51) with the following (black could be replaced with any CSS colour-like string e.g. #000000 or rgb(0, 0, 0) etc.):

plot.add_tools(HoverTool(tooltips="@Country", tooltip_arrow_color='black', point_policy='follow_mouse'))

It looks like this:

image

Are there other attributes besides the arrow colour that should be configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants