Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary parameter #10

Closed
bokkypoobah opened this issue Feb 8, 2018 · 0 comments
Closed

Remove unnecessary parameter #10

bokkypoobah opened this issue Feb 8, 2018 · 0 comments
Labels
Fixed and tested Improvement Low Importance

Comments

@bokkypoobah
Copy link
Owner

bokkypoobah commented Feb 8, 2018 •
edited

From oleksii's audit:

BokkyPooBahsTokenTeleportationServiceSmartContract/contracts/BTTSTokenFactory.sol

Line 342 in 06c15ed

function approveAndCall(Data storage self, address tokenContract, address spender, uint tokens, bytes data) public returns (bool success) {
why not using address(this) instead of passing it as a parameter tokenContract ? Same in the other functions with tokenContract parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed and tested Improvement Low Importance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bokkypoobah