Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI to GitHub CI Workflow #203

Merged
merged 7 commits into from Feb 24, 2021
Merged

Travis CI to GitHub CI Workflow #203

merged 7 commits into from Feb 24, 2021

Conversation

rmm5t
Copy link
Collaborator

@rmm5t rmm5t commented Feb 18, 2021 •
edited

What does it do?

  • Add github CI workflow
  • Add activesupport 6 to build matrix
  • Update readme CI badge
  • Lock tzinfo on activesupport 3
  • Limit activesupport 4 in build matrix
  • Remove travis build matrix
  • Add Ruby 3.0 support

What else do you need to know?

Passing CI suite:
https://github.com/rmm5t/business_time/actions/runs/576941888

Issues

Fixes #199
Closes #200

@rmm5t rmm5t mentioned this pull request Feb 18, 2021
Closed
@daande
Copy link

daande commented Feb 19, 2021

Can we get this merged?

bmalets
bmalets approved these changes Feb 21, 2021
View reviewed changes
Copy link

@bmalets bmalets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bokmann bokmann merged commit 9127730 into bokmann:develop Feb 24, 2021
@rmm5t rmm5t deleted the travis-to-github branch February 24, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmalets bmalets bmalets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Ruby 3.0.0
4 participants
@rmm5t @daande @bmalets @bokmann