New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't seem to work on Rails 4.1 #88
Comments
The test matrix includes rails master (4.1) and passes. With that, I haven't spent any time with the direct combination of the two in a real app myself yet. Sanity check: Did you remember to |
Yes, did both. Added several other gems as well, which did load. Also ran |
I'm working on Rails 4.1 too, it went well as following. add to Gemfile do add to application.css
and, restart rails server. |
Doesn't work for me too... Rails 4.1 without SASS... |
Yeah, this does not work on rails 4.1 for me either. Font files is not copied over to public/assets on precompile. |
So, we're getting some mixed reviews of whether this works on Rails 4.1 or not. I haven't yet tried it myself, and I don't know when I'll get a chancge to try the combination, but if anyone has more insight as to why some people are having problems and/or if there's something we need to fix as part of the asset wrapper, I'm all ears. In other words, pull-requests welcome. Meanwhile, is this only an issue during asset compilation for production or are people also having trouble in development? |
I was using To temporarily fix, I just simply copied over the assets from the newer lib to the older lib and it's works fine on Not sure if this helps in any way, just thought I'd share my experience in case it helps resolve the issue some of you are having. |
That's probably related (Rails 4.1.0). I'm getting:
in the browser when rails is in development mode . |
@licatajustin @managr If you're seeing some icons but not the new ones after updating to font-awesome-rails 4.1.0.0, that's a separate issue from the one reported here, and you probably have an asset caching problem with your stylesheet. See #95, and please read the debugging steps in the contribution guidelines. |
Same issue as @managr here with Rails 4.1.1... after updating the gem I get the following error:
And in my browser the same error commented above:
|
It's broken on rails 4.1 for me also. I get the following error:
I am using SCSS and have the appropriate import in my @import "font-awesome"; My relevant gems:
|
Had a problem
Comparing with working app and downgrading gem by gem, I found, that downgrade of "bootstrap-sass" from '3.1.1.1' to '3.1.1.0' fix the problem. I had following config before and get "3.1.1.1" installed.
so, you can check if this solution works for you. |
I had the same problem as @rkyrychuk and downgrading |
In my case I'm not using |
It can be one of the During debugging I had an warning from one of gem that it resolve |
I'm using it right now and works great. 4.1.1, ruby 2.1.2, font-awesome-rails 4.0.3.2 |
I tried using webrick (in production mode) with ruby 2.1.0 with rails 4.1.1 and work fine. I'm installing ruby 1.9.3 to test again. I have 2 servers, 1.9.3 and 2.0.0 in production and not work with both. |
I tried switch the bootstrap-sass to 3.1.1.0 and still not working. In Chrome Inspector, i got 404 assets/fontawesome-webfont.woff but the assets precompiled are fontawesome-webfont-027499bf57aacf4f676ca8f2143254ac.woff. Is the same to all fontawesome assets |
Not working in Rails 4.1.1, Ruby 2.1.2, no SASS. |
Okay everyone. I finally found myself in a Rails 4.1 + font-awesome-rails app. I cannot reproduce the problem that everyone is reporting. Everything works as expected in both development and production (with precompiled assets). I'm using the latest version of bootstrap-sass, rails, font-awesome-rails
I'm inclined to close this issue out unless we can get a better assessment of the underlying problem and that the problem actually exists with this gem. |
Just wanted to note that since my previous comment I have made a lot of changes to my Gemfile and now |
Sorry I've been silent on this; I've been meaning to find the time to reproduce in something a little more complicated. I'm using this in a rails 4.1 app with nothing special about the development or production environments, and it 'just works'. I know the asset pipeline can be a fickle beast, but if this isn't working for you, I'd suggest auditing the details of your environment - what other gems are you using that mess with the pipeline, what order are they loaded in, etc. I'm not suggesting the periodic chatter on this issue isn't a sign of a problem, but I am suggesting that with the fickleness of the asset pipeline, to move further on this issue (and even determine what piece of code is responsible), we'd need a minimal viable app that illustrates the issue. |
I can still reproduce this very easily.
The error happens for me. It looks like the version of sass, 3.2.19, that the app is using, uses this call, which checks for files with extensions that are either I don't know why it works within an application, but in those tests for that extension it definitely fails. I haven't yet been able to track down what the difference is. |
OK, so within an application the extensions look like this:
But within the extension, they look like this:
Where are those coming from? Is that a Sprockets thing? shrug |
Aha, it's a Case closed? |
Solved the issue for me on several spree extensions. |
Could someone explain how @radar 's fix applies to other apps? Where do I need to be requiring sass-rails for this to be fixed? I'm seeing the same problem as @managr even on bootstrap-sass 3.1.1.0 |
@radar Thanks for hunting this issue down and following through with additional details. Much appreciated! Overall, is there anything this gem can do to help alleviate these problems? i.e. Do you think it is safe to close this issue out?
Everyone else, is this a possibility? |
@hcarver Can you grant me access to the app you're seeing this on and steps to repro? I think I can fix it. |
@rmm5t No problem. Happy to help :) Yes I think it's OK to close this issue out. The cause is that for whatever reason, The fix is to ensure that this file is required, somewhere. Usually that's done automatically through the stuff in the |
@radar I can't grant you access I'm afraid. I'm not sure this is the right fix for me - I am already requiring What did fix it for me was downloading to v3.1.1.0 of bootstrap-sass and removing v3.1.1.1. Seems obvious, I know, but I hadn't thought to remove the old version before. Anyway, doing that and restarting the server fixed the problem. I see that requiring |
@hcarver That's fine. But where in your Gemfile is that line? is it within an asset group? |
@radar No, it's not in an asset group. From the top of my Gemfile, removing a few comments...
|
@hcarver Seems fine. Are you certain that
Then in |
@radar Definitely.
For debugging's sake, I tried with both versions of bootstrap-sass (3.1.1.0 and 3.1.1.1). Same result both times, definitely loaded. |
Great. Doing that now.
@radar Thanks! |
very simple just put .scss.erb extention to awsome fonts in stylesheets toont-awesome.min.scss.erb and font-awesome.scss.erb |
I was have the same problem. Because I switch the branch without restart the server. |
I'm working on Rails 4.1, and the gem doesn't seem to work.
The helper functions are not available (
undefined_method
). And I can't load the stylesheet both withrequire
in a manifest file and with@import
in a.scss
file.Is Rails 4.1 unsupported?
The text was updated successfully, but these errors were encountered: