removal of RESCRIPt RNA types, etc.. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misialq
reviewed
Apr 9, 2021
There was a problem hiding this comment.
Thanks @mikerobeson, good catch! Looks good - just a little flake issue. As to the transformers: should we maybe at least create an issue for transferring them over to q2-types, not to forget later?
I'll approve once the CI ran through ✅
|
Thank you @mikerobeson and @misialq! @mikerobeson, could you please update the readme to say that the minimum qiime version is now 2021.4? @misialq, do not merge! until after the 2021.4 release. (I’m sure you knew that already, but best to be explicit.) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As RNA types, formats, and transformers have been added to base QIIME 2 as of PR (qiime2/q2-types#256), this created problems with RESCRIPt's own RNA types. This PR removes all RESCRIPt RNA types and uses the new base QIIME 2 RNA types. Some transformers (i.e. RNA -> DNA) in RESCRIPt that should be migrated over to
q2-types. But I left them alone for now.All unit tests and flake8 checks pass. I've also installed these PR changes into my
qiime2-devenvironment w/o warnings of duplicated types, etc...