Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/parser combinator library #3

Closed
wants to merge 7 commits into from
Closed

Topic/parser combinator library #3

wants to merge 7 commits into from

Conversation

bokuo-okubo
Copy link
Owner

12/14時点差分

@bokuo-okubo bokuo-okubo force-pushed the topic/parser-combinator-library branch from 57631d7 to 295e688 Compare December 14, 2015 13:38
@bokuo-okubo bokuo-okubo force-pushed the topic/parser-combinator-library branch from 39af300 to 0d94fa4 Compare December 15, 2015 02:02
mosson
mosson reviewed Dec 15, 2015
View reviewed changes
agent-ios/MyPlayground.playground/Contents.swift

import Cocoa

class Regexp {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

汎用的な名前は避ける

@mosson
Copy link
Collaborator

mosson commented Dec 15, 2015

きちんとコミットまとめるなりしてもらわないと困る

@mosson
Copy link
Collaborator

mosson commented Dec 15, 2015

xcxxxx系統のファイルはコミット分けて欲しい。見づらい。

@mosson mosson closed this Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bokuo-okubo @mosson