Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: boundsByDirection #689

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Feature: boundsByDirection #689

merged 1 commit into from
Oct 30, 2020

Conversation

eseQ
Copy link
Contributor

@eseQ eseQ commented Oct 16, 2020

bump version to 6.7.0

It PR about new feature.
Original behavior:

Original behavior

That behavior because window`s right side close to resize component and component try resize like by right handler

boundsByDirection enabled behavior:

Enabled behavior

Testing Done

Test

bump version to 6.7.0
@bokuweb
Copy link
Owner

bokuweb commented Oct 17, 2020

@eseQ Thanks for your request :). I still don't understand the behavior you expect yet. Could you please add example to storybook ?

@eseQ
Copy link
Contributor Author

eseQ commented Oct 19, 2020

@bokuweb now I can only create sandbox demo. I think this will help to understand.

@bokuweb
Copy link
Owner

bokuweb commented Oct 19, 2020

@eseQ Thanks :) I'll check it later

@bokuweb
Copy link
Owner

bokuweb commented Oct 25, 2020

@eseQ Sorry for late. Looks good. I'm wondering if I should make this feature the default enable or not. Are there any possible disadvantages?
If there are no disadvantage, I'll remove this boundsByDirection prop and always enable this feature.

@eseQ
Copy link
Contributor Author

eseQ commented Oct 26, 2020

@bokuweb I will have to test more meticulously. Now I am using boundsByDirection but why? I'll respond later.

@bokuweb bokuweb merged commit 9a1728d into bokuweb:master Oct 30, 2020
@bokuweb
Copy link
Owner

bokuweb commented Nov 5, 2020

@eseQ Sorry for late. I published v6.8.0.

I'm wondering if I should make this feature the default enable or not. Are there any possible disadvantages?

I reconsidered about it, I think we should provide this feature as optional feature to avoid breaking change.

@eseQ
Copy link
Contributor Author

eseQ commented Nov 6, 2020

@bokuweb Exactly my thought. I still doesn`t have time for detail test.
I think it`s can be optional feature for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants