Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add false to ResizableProps.enable #789

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Add false to ResizableProps.enable #789

merged 1 commit into from
Aug 10, 2023

Conversation

inokawa
Copy link
Contributor

@inokawa inokawa commented Aug 10, 2023

Proposed solution

In current behavior, all resizers are disabled if we pass false to ResizableProps.enable.

re-resizable/src/index.tsx

Lines 888 to 890 in da458ab

if (!enable) {
return null;
}

However current type definition does not accept false so I fixed the type.

Tradeoffs

N/A

Testing Done

Tested with passing false to actual Resizable component.

Copy link
Owner

@bokuweb bokuweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bokuweb bokuweb merged commit bce0819 into bokuweb:master Aug 10, 2023
@inokawa inokawa deleted the enable-false branch August 10, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants