Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix horizontal and vertical panes #24

Closed
haraldox opened this issue Mar 16, 2016 · 9 comments
Closed

Mix horizontal and vertical panes #24

haraldox opened this issue Mar 16, 2016 · 9 comments

Comments

@haraldox
Copy link
Contributor

@bokuweb: great work on version 0.2.0! :)

now that you got vertical panes implemented (by popular demand ;) how much effort would it be in your opinion, to mix horizontal and vertical panes, i.e. freely drag horizontal to vertical panes and vice versa?

see yellowiscool/LeCadreur as an example (click on flip - top right corner and then drag by color handles)

also kind of like a combined version of STRML/react-grid-layout and its horizontal counterpart cmelion/react-grid-layout

or even gridster.js

Thanks for your feedback! I checked out your github repos as well as blog and you have very interesting projects ... I can feel this component becoming big!

@bokuweb
Copy link
Owner

bokuweb commented Mar 16, 2016

@haraldox Hi! Thanks for the link!

Your image is react-split-pane(http://react-split-pane.surge.sh/) where sortable/draggable feature is added?
And It's same demand this request? #20

And if so, It should be implemented as another component(like, react-sortable-split)
I'll going to implement react-sortable-split, but It is earlier to complete a react-sortable-pane.
Does it is useless for STRML/react-grid-layout is not that freely drag(possible grid drag)?

Thanks for your feedback! I checked out your github repos as well as blog and you have very interesting projects ... I can feel this component becoming big!

thanks!!

@haraldox
Copy link
Contributor Author

+1

indeed, for me react-grid-layout is not suitable because you can drag elements either vertically or horizontally but not both. also, no splitting there like LeCadreur

Actually, I think your library could be a long-awaited and worthy competitor to @deepstreamIO's commercial solution GoldenLayout which is open source but GPL-licensed (deepstreamIO/golden-layout) but doesn't use absolute positioning. Especially augmenting that library with react would be interesting...

future library react-sortable-split would also be an alternative to @tomkp's excellently simple and elegant react-split-pane maybe inciting friendly competition? ;)

hope my positive feedback is constructive! :)

@bokuweb
Copy link
Owner

bokuweb commented Mar 17, 2016

@haraldox Thanks for the link and thanks your feedback.
I will use GoldenLayout as reference.

If I started to implement the react-sortable-split, we will contact you

@haraldox
Copy link
Contributor Author

wow, that was fast! :)

@haraldox
Copy link
Contributor Author

@bokuweb Just to update you: GoldenLayout will be updated to support React, but probably still won't support absolute positioning ... can you give me a few pointers on how to implement react-sortable-split? maybe we can collaborate! :)

@bokuweb
Copy link
Owner

bokuweb commented Mar 31, 2016

@haraldox oh.thanks.
Are you in a hurry?
I'm going to create react-sortable-split prototype this or next holiday.

@haraldox
Copy link
Contributor Author

@bokuweb Yes, I am but no worries... ;-)

just out of curiosity, what do you mean by "holiday" in japan? thanks

On Thu, Mar 31, 2016 at 12:39 PM bokuweb notifications@github.com wrote:

@haraldox https://github.com/haraldox oh.thanks.
Are you in a hurry?
I'm going to create react-sortable-split prototype this or next holiday.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#24 (comment)

@bokuweb
Copy link
Owner

bokuweb commented Mar 31, 2016

what do you mean by "holiday" in japan?

It means, this weekend or next weekend.
I'll try if possible

https://github.com/bokuweb/react-sortable-split

@haraldox
Copy link
Contributor Author

haraldox commented Apr 4, 2016

@bokuweb Wow, that's fast! Thanks for the update 👍 keep up the great work! :)

@bokuweb bokuweb closed this as completed Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants