Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix onDragEnd bug and optimised event binding #66

Merged
merged 1 commit into from Aug 1, 2017
Merged

fix onDragEnd bug and optimised event binding #66

merged 1 commit into from Aug 1, 2017

Conversation

leon3s
Copy link
Contributor

@leon3s leon3s commented Aug 1, 2017

Proposed solution

Swapped window.addEventListener to this.panes.addEventListener and added if statement for isSortable

Testing Done

This have been tested with index.html

@leon3s leon3s mentioned this pull request Aug 1, 2017
Closed
bokuweb
bokuweb approved these changes Aug 1, 2017
View reviewed changes
Copy link
Owner

@bokuweb bokuweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 👍

@bokuweb bokuweb merged commit 207d22e into bokuweb:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bokuweb bokuweb bokuweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leon3s @bokuweb