Added HEADER_CHECKS configuration option #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokysan
requested changes
Sep 26, 2019
header_checks
Outdated
| /^Received:.*with ESMTPSA/ IGNORE | ||
| /^Received:.*with ESMTPS/ IGNORE | ||
| /^Received:.*with SMTP/ IGNORE | ||
| /^Received:/ IGNORE |
There was a problem hiding this comment.
Can you just make sure that the lines are aligned?
| ### `HEADER_CHECKS` | ||
|
|
||
| Each message header line is compared against a pre-configured list of patterns. When a match is found the corresponding action is executed. Set to a non-empty string (usually "1" or "yes") enable. | ||
|
|
There was a problem hiding this comment.
We'll need additional description here -- e.g. instructions on how to add the file. This is not apparent from documentation.
|
Thank you for your review. Can you please check again? |
ghost
requested a review
from 
|
Thank you, I'll merge this into the main branch but I'll most likely move the |
|
Hi, after consideration I've renamed your variable to |
|
Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the HEADER_CHECKS 1 option with a sample configuration.
Each message header line is compared against a pre-configured list of patterns. When a match is found the corresponding action is executed.
Type of change
How Has This Been Tested?
I have tested this version of the docker image in a flask application and checked if the headers where ignored or replaced.