Allow setting empty ALLOWED_SENDER_DOMAINS #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting an empty
ALLOWED_SENDER_DOMAINSvariable. The default behaviour remains the same (emptyALLOWED_SENDER_DOMAINSwill throw an error), but it is posible to override this behaviour via a new variableALLOW_EMPTY_SENDER_DOMAINS.The use case is being able to set restrictions on the recipient and not on the sender (anyone can send mails but just to a single domain for instance). This can be achieved by extending the image through custom scripts, and it's cleaner if the base image supports a way not to enforce setting a value on it.