Adds Native.make_error(message) and refactors functions handler #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 gave you commit access. feel free to merge when rebased. I'd still prefer if you open PRs so I can review, just so I can see how the code is changing. |
edward
force-pushed
the
use-actual-error-function
branch
from
45dfec3
to
5d4ca17
Compare
|
@bolandrm I am humbled 👯 Thanks! |
|
Also: sounds good – I prefer the code review anyway :) (At Shopify there are usually 2+ reviewers to any code change and they all happen in regular PRs.) |
edward
pushed a commit
that referenced
this pull request
Jul 13, 2015
Adds Native.make_error(message) and refactors functions handler
michael-gillett
pushed a commit
to michael-gillett/sassc-ruby
that referenced
this pull request
Apr 25, 2019
Act-439: rely on go_links_db models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review @bolandrm