Bld 41686 #23
Merged
Bld 41686 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bld 38223
ElizaSapir
approved these changes
Nov 10, 2020
nissopa
reviewed
Nov 11, 2020
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
||
| if let formField = self.formInfo.form.formFields[0] as? BCFormField{ |
There was a problem hiding this comment.
why using [0] instead of .first it can cause crash
| } | ||
|
|
||
| @IBAction func submitTapped(_ sender: Any) { | ||
| (self.formInfo.form.formFields[0] as? BCFormField)?.label = self.formTitle.text |
|
|
||
|
|
||
|
|
||
| extension BoldFormViewController: BoldForm { |
There was a problem hiding this comment.
instead of using formInfo and formDelegate we can use the form and delegate
There was a problem hiding this comment.
I'm not sure if it will work.
This solution is taken from the documentation we currently have. (https://github.com/Logmein-Bold-Mobile/bold360-mobile-docs-ios/blob/master/PresentFormsIOS.md)
Don't you think it's there on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.