Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning with PHP 8.1: Deprecated function: trim() #72

Merged
merged 1 commit into from Aug 6, 2022

Conversation

Amadeco
Copy link
Contributor

@Amadeco Amadeco commented Aug 5, 2022

Using Magento 2.4.4
and
PHP version 8.1.8

The module is currently throwing an error in the checkout process when the field is empty.

Reference : #71 (comment)

Using Magento 2.4.4
and 
PHP version 8.1.8

The module is currently throw an error in the checkout process.

Reference : boldcommerce#71 (comment)
@perryholden
Copy link

We also ran into this issue earlier and patched it. In fact, I was just in the process of submitting a PR for this exact when I saw this one come through. 😄 Hopefully this gets merged quickly. 🤞

@boldsidney
Copy link
Contributor

HI @Amadeco,
Thanks for reporting. I've managed to reproduce it when selecting an order without a comment in the my orders section and the provided solution solves it.

I'll merge this and put up a new version.

@boldsidney boldsidney merged commit d35df4f into boldcommerce:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants