Fix #13; move default threshold into Stoplight module

bolshakov · Aug 13, 2014 · a5f3b60 · a5f3b60
1 parent cc3a862
commit a5f3b60
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/lib/stoplight.rb b/lib/stoplight.rb
@@ -13,6 +13,9 @@ module Stoplight
   # @return [Gem::Version]
   VERSION = Gem::Version.new('0.1.0')
 
+  # @return [Integer]
+  DEFAULT_THRESHOLD = 3
+
   class << self
     extend Forwardable
 
@@ -59,7 +62,7 @@ def red?(name)
     # @param name [String]
     # @return [Integer]
     def threshold(name)
-      data_store.threshold(name) || Light::DEFAULT_THRESHOLD
+      data_store.threshold(name) || DEFAULT_THRESHOLD
     end
   end
 end
diff --git a/lib/stoplight/light.rb b/lib/stoplight/light.rb
@@ -2,9 +2,6 @@
 
 module Stoplight
   class Light
-    # @return [Integer]
-    DEFAULT_THRESHOLD = 3
-
     # @return [Array<Exception>]
     attr_reader :allowed_errors
 

diff --git a/spec/stoplight/light_spec.rb b/spec/stoplight/light_spec.rb
@@ -215,8 +215,7 @@
     subject(:result) { light.threshold }
 
     it 'uses the default threshold' do
-      expect(result).to eql(
-        described_class.const_get(:DEFAULT_THRESHOLD))
+      expect(result).to eql(Stoplight::DEFAULT_THRESHOLD)
     end
   end
 end
diff --git a/spec/stoplight_spec.rb b/spec/stoplight_spec.rb
@@ -112,7 +112,7 @@
     subject(:result) { described_class.threshold(name) }
 
     it 'uses the default threshold' do
-      expect(result).to eql(Stoplight::Light::DEFAULT_THRESHOLD)
+      expect(result).to eql(Stoplight::DEFAULT_THRESHOLD)
     end
 
     context 'with a custom threshold' do