Search string is emphasized (bold) in UI #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bolsinga
commented
Jun 15, 2024
bolsinga
commented
- RankingList now defers rendering LibraryComparable.name to a closure
- ArtistList and VenueList will render their names emphasizing the searchString in the UI.
- RankingList now defers rendering LibraryComparable.name to a closure - ArtistList and VenueList will render their names emphasizing the searchString in the UI.
bolsinga
added a commit
that referenced
this pull request
Jun 16, 2024
Basically Typing "G " for "Going Well" would have the markdown of "Goin**g **Well" and this does not render properly. Revert "Search string is emphasized (bold) in UI (#812)" This reverts commit 5b9ff19. Revert "fix when emphasizing the empty string (#811)" This reverts commit 552914b. Revert "add utility the emphasize case insensitive portions of strings (#810)" This reverts commit 86d6b3d.
Merged
bolsinga
added a commit
that referenced
this pull request
Jun 16, 2024
bolsinga
added a commit
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.