fix: trigger active pathway from pathways

boltdesignsystem · Aug 22, 2019 · 057dd0a · 057dd0a
1 parent 71d4f55
commit 057dd0a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/packages/micro-journeys/src/interactive-pathway.js b/packages/micro-journeys/src/interactive-pathway.js
@@ -52,6 +52,7 @@ class BoltInteractivePathway extends withLitHtml() {
 
   setActive(isActive = true) {
     this.isActivePathway = isActive;
+    this.setActiveStep(0);
     this.triggerUpdate();
   }
 
@@ -66,16 +67,6 @@ class BoltInteractivePathway extends withLitHtml() {
 
   connectedCallback() {
     super.connectedCallback();
-    if (this.getAttribute('total-steps')) {
-      console.error(
-        'The attribute "total-steps" is present and should not be.',
-      );
-    }
-
-    // If we fire `this.setActiveStep(0)` here it won't work since parents are connected before children, so we place it in `setTimeout` to put it at bottom of call stack
-    setTimeout(() => {
-      this.setActiveStep(0);
-    }, 0); // @todo replace this with a nice onScroll/inView trigger
   }
 
   /**

diff --git a/packages/micro-journeys/src/interactive-step.js b/packages/micro-journeys/src/interactive-step.js
@@ -44,10 +44,6 @@ class BoltInteractiveStep extends withLitHtml() {
 
   connectedCallback() {
     super.connectedCallback();
-    if (this.getAttribute('step')) {
-      console.error('The attribute "step" is present and should not be.');
-    }
-
     this.addEventListener('bolt:transitionend', this.handleAnimationEnd);
   }