Skip to content

Commit

Permalink
feat: add todos regarding 3.0 deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Morse committed Sep 3, 2019
1 parent e8cae04 commit 2245f24
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/components/bolt-background/src/background.scss
Expand Up @@ -79,6 +79,7 @@ bolt-background {
animation: a-bolt-zoom-in-out 45s ease-in-out infinite both;
}

// todo: remove in v3.0, video background in deprecated
.c-bolt-background__video {
top: 0;
right: 0;
Expand Down
5 changes: 4 additions & 1 deletion packages/components/bolt-background/src/background.twig
Expand Up @@ -55,6 +55,8 @@
{% for item in contentItems %}

{% set itemAttributes = item.pattern ~ "Attributes" %}

{# todo: in v3.0 remove reference to Video, no longer supported #}
{# Image expects "ratio" to be passed as string, Video expects boolean #}
{% set ratioValue = item.pattern == "image" ? "none" : false %}

Expand All @@ -65,7 +67,8 @@
}
}) %}
{% endif %}


{# todo: in v3.0 nix the pattern_template pattern? #}
{% include pattern_template(item.pattern) with item | merge({
ratio: ratioValue,
lazyload: item.lazyload ?? true,
Expand Down

0 comments on commit 2245f24

Please sign in to comment.