feat: Make current pagination item not a link

See discussion on #815
boltdesignsystem · Jul 17, 2018 · c0e5690 · c0e5690
1 parent 2c27e74
commit c0e5690
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/components/bolt-pagination/pagination.scss b/packages/components/bolt-pagination/pagination.scss
@@ -77,6 +77,7 @@ bolt-pagination {
   &.is-current {
     color: $bolt-pagination-item-text-color-current-notheme;
     background-color: $bolt-pagination-item-bg-color-current-notheme;
+    opacity: 1;  // Current item is not a link so its styling shouldn't change based on state.
   }
 }
 

diff --git a/packages/components/bolt-pagination/pagination.twig b/packages/components/bolt-pagination/pagination.twig
@@ -95,14 +95,14 @@
         {% if key == current %}
           {% set linkAttributes = linkAttributes.addClass("is-current") %}
           {% set linkAttributes = linkAttributes.setAttribute("aria-current", "true") %}
-          <a {{ linkAttributes }}>
+          <span {{ linkAttributes|without("href") }}>
             <span class="{{ "#{baseClass}__text" }}">
               <span class="u-bolt-visuallyhidden">
                 You are currently on page
               </span>
               {{- key -}}
             </span>
-          </a>
+          </span>
         {% else %}
           <a {{ linkAttributes }}>
             <span class="{{ "#{baseClass}__text" }}">