Added the search dialog to the standalone file editor interface #4890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing search functionality to edit file page
|
Travis failure is PHP 5.3 memory use with Composer. @rarila should this be compiled together, and forward port strategy? |
|
@GawainLynch hmmm, I think it can stay this way for now. Forward porting should be no problem. |
GwendolenLynch
added a commit
that referenced
this pull request
Feb 23, 2016
Added the search dialog to the standalone file editor interface
|
Thanks @xpika 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Logging in and selecting
File Management > View/Edit templates
Doing a Ctrl+F for search does not load the search dialog like it does when editing a page from a content type. As you may know using the native browser search does not work with codemirror for any longer than a couple of pages.
Added the search dialog plugin script resource to the template