Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IPv6 adresses can be longer than the used column #5316

Closed
t2t2 opened this issue May 12, 2016 · 1 comment
Closed

[BUG] IPv6 adresses can be longer than the used column #5316

t2t2 opened this issue May 12, 2016 · 1 comment

Comments

@t2t2
Copy link

t2t2 commented May 12, 2016

Currently IP columns are up to 32 characters in length, but IPv6 can be up to 39 or 45 characters long

Details

  • Relevant Bolt Version: 3.0
  • Install type: Composer install
  • PHP version: 5.6.20
  • Used webserver: Apache

Reproduction

Trying to log on with a connection with an IPv6 address that is longer than 32 characters returns an error.

Relevant files:

https://github.com/bolt/bolt/blob/release/3.0/src/Storage/Database/Schema/Table/AuthToken.php#L22
https://github.com/bolt/bolt/blob/release/3.0/src/Storage/Database/Schema/Table/LogSystem.php#L24
https://github.com/bolt/bolt/blob/release/3.0/src/Storage/Database/Schema/Table/Users.php#L22

@GwendolenLynch
Copy link
Contributor

Ah crap… I had a commit on this one months ago and must have don't something stupid 😦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants