Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Phase II: Symfony 4/Flex & Silex 2 project filesystem layout #6982

Merged
merged 11 commits into from
Sep 15, 2017
Merged

[4.0] Phase II: Symfony 4/Flex & Silex 2 project filesystem layout #6982

merged 11 commits into from
Sep 15, 2017

Conversation

GwendolenLynch
Copy link
Contributor

@GwendolenLynch GwendolenLynch commented Sep 6, 2017

This is Phase II of the changes started in #6739 to remodel the project's internal layout, which looks something like:

%site%/
├─ app/
│  ├─ database/
│  └─ translations/
├─ assets/       # Formerly app/src/
├─ bin
│  └─ nut
├─ config/
│  └─ extensions/
├─ public/
│  ├─ bolt/      # Formerly in app/view/
│  │  ├─ css/
│  │  ├─ fonts/
│  │  ├─ img/
│  │  └─ js/
│  ├─ files/
│  ├─ theme/
│  └─ index.php
├─ src/
├─ templates/
│  ├─ bolt/      # Formerly app/view/twig/
│  ├─ defaults/  # Formerly app/theme_defaults/
│  └─ toolbar/   # Formerly app/view/toolbar/
├─ var/
│  ├─ cache/
│  ├─ logs/
│  └─ sessions/
├─ tests/
└─ vendor/

For reference this is based around various discussions in #development, and the following upstream:

The thinking with respect to applying this the to repository version is centred around consistency with both our installed product, and application structure moving forward.

Let the discussion begin. 😄

@GwendolenLynch GwendolenLynch added the RFC Request For Comments label Sep 6, 2017
@bobdenotter
Copy link
Member

screen shot 2017-09-06 at 20 53 02

🙄

Kidding aside, looks good to me. Happy that under SF 4 we can keep theme/ with the templates as a whole under public/. This will keep frontend devs happy.

bobdenotter
bobdenotter previously approved these changes Sep 6, 2017
@GwendolenLynch
Copy link
Contributor Author

GwendolenLynch commented Sep 6, 2017

But … 😜
image

Happy that under SF 4 we can keep theme/ with the templates as a whole under public/. This will keep frontend devs happy.

Well, yes, but that is a separate point here. This is just structure for the core layout, all this will still end up installed in vendor/bolt/bolt/ and we copy what we need, e.g. assets, to where we need.

That said, yeah, while I think it is better to have your Twig in %site%/templates/ and your web assets in %site%/public/, I don't see a point in forcing that on people, rather I think giving them a choice is the fairest solution 😄

@bobdenotter bobdenotter merged commit 6077a01 into bolt:master Sep 15, 2017
@GwendolenLynch GwendolenLynch deleted the feature/flex-layout branch September 15, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants