Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form options feature #242

Merged
merged 3 commits into from
May 20, 2018
Merged

Add form options feature #242

merged 3 commits into from
May 20, 2018

Conversation

artggd
Copy link
Contributor

@artggd artggd commented Mar 5, 2018

Hi,

This PR allows the user to define global form options, fixing #241.

I documented it a bit, engrish and spell review would be much appreciated 🙂

Arthur Guigand added 3 commits March 5, 2018 20:22
This allows the user to define global form options.
/**
* Form options configuration for BoltForms
*
* Copyright (c) 2014-2016 Gawain Lynch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wrote it, so i think this should have your name on it. ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the copyright is a global, the @author is the correct one to use here and has Arthur's attribution

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that.. I was thinking of @author, which does have your name on it..

Must be the lazy-saturday-afternoon-beers. 🍻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add this for the record (as details were just now discussed in person), the reason being that any licence change needs the written concent of all copyright holders … now the GPL will keep this FOSS licenced, but we don't know what the future holds and might what to switch to the WTFPL or similar 😜 at some stage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be the lazy-saturday-afternoon-beers. 🍻

I'll 'ave a 'alf

@rossriley rossriley merged commit b6b8d21 into bolt:4.2 May 20, 2018
@artggd
Copy link
Contributor Author

artggd commented May 22, 2018

🎉

@artggd artggd deleted the feature_form_options branch May 22, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants