Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize form data if we are passed a class that can be serialized #250

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

rossriley
Copy link
Collaborator

Fixes #248

This is mainly to handle image uploads since they get to the Contenttype handler as an instance of Submission\File rather than an array.

At this point the field save will not work so we can call the jsonSerialize method to get the prepared data. Using this approach allows other custom field handlers in the future to do the same if needed.

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bobdenotter bobdenotter merged commit 9e9bb74 into bolt:4.2 Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants