fix: update JPG check to account for JPGs that have query strings

sghoweri · sghoweri · commit d45e55966bfc · 2019-10-24T15:47:46.000-04:00
diff --git a/packages/components/bolt-image/src/image.js b/packages/components/bolt-image/src/image.js
@@ -184,7 +184,12 @@ class BoltImage extends withLitHtml() {
       }
     }
 
-    const _isJpg = src && src.split('.').pop() === 'jpg';
+    const _isJpg =
+      src &&
+      src
+        .split('.')
+        .pop()
+        .includes('jpg');
     const _canUseRatio = ratioW > 0 && ratioH > 0 && useRatio && !cover;
     // Only JPGs allowed, PNGs can have transparency and may not look right layered over placeholder
     const _canUsePlaceholder = (_canUseRatio || cover) && _isJpg;

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,12 @@ class BoltImage extends withLitHtml() {`
`184`	`184`	`}`
`185`	`185`	`}`
`186`	`186`
`187`		`- const _isJpg = src && src.split('.').pop() === 'jpg';`
	`187`	`+ const _isJpg =`
	`188`	`+ src &&`
	`189`	`+ src`
	`190`	`+ .split('.')`
	`191`	`+ .pop()`
	`192`	`+ .includes('jpg');`
`188`	`193`	`const _canUseRatio = ratioW > 0 && ratioH > 0 && useRatio && !cover;`
`189`	`194`	`// Only JPGs allowed, PNGs can have transparency and may not look right layered over placeholder`
`190`	`195`	`const _canUsePlaceholder = (_canUseRatio \|\| cover) && _isJpg;`