Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -R to be passed *after* other global flags (-t and -D) #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janvrany
Copy link

Using custom tags and a recursive refresh fails when creating snapshot with error:

ERROR: unrecognized zrep subcommand -R

This is because it executes something like

ssh  source_host zrep -t zrep_tag -R snaponly fs

The -R flag comes after -t flag. However, zrep (prior this commit) required -R to be the fist flag.

This commit moves the check for -R flag and initialization of ZREP_R to the same loop that checks for other global flags (currently -t and -D). This fixes the issue.

Using custom tags and a recursive `refresh` fails when creating snapshot
with error:

   ERROR: unrecognized zrep subcommand -R

This is because it executes something like

   ssh  source_host zrep -t zrep_tag -R snaponly fs

The `-R` flag comes after `-t` flag. However, `zrep` (prior this commit)
required `-R` to be the fist flag.

This commit moves the check for `-R` flag and initialization of `ZREP_R`
to the same loop that checks for other global flags (currently `-t` and
`-D`). This fixes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant