Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Macro compiler dev #36

Merged
merged 108 commits into from
Mar 5, 2021
Merged

WIP: Macro compiler dev #36

merged 108 commits into from
Mar 5, 2021

Conversation

plaidfinch
Copy link
Contributor

No description provided.

plaidfinch
plaidfinch commented Feb 22, 2021
View reviewed changes
Copy link
Contributor Author

@plaidfinch plaidfinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments after going through the changes to support spans. The most broad-scoped question I have is about the way error information is collected and propagated. What are your thoughts @sdleffler?

dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
dialectic-compiler/src/lib.rs Show resolved Hide resolved
dialectic-compiler/src/lib.rs Outdated Show resolved Hide resolved
sdleffler and others added 27 commits February 22, 2021 13:37
@sdleffler
Duplicate build.rs Session enum into dialectic-compiler stub
4e2c91e
@sdleffler
Rough CFG to session AST sketch
08add47
@sdleffler
Add more parser-friendly AST and transform to CFG.
9dd8742
@sdleffler
Initial TokenStream parser for 'expression' level AST nodes
8b454ab
@sdleffler
Limited SessionDef parsing and test.
0fdcb98
@sdleffler
Preliminary invocation parsing/compilation
cdeee50
@sdleffler
Allow nontrivial nodes as callees
97a4002
@sdleffler
Remove unnecessary parentheses from macro language
dc8ec8c
@sdleffler
Support planned Then construct
6d6d847
@sdleffler
Small reword in error messages
2a056b1
@sdleffler
dialectic-macro wrapper crate
69145a3
@sdleffler
Depend on dialectic-macro, reexport from prelude, and test in hello.r…
a783dc7 
…s example
@sdleffler
Fix forgetting to run break elimination pass in dialectic-macro and t…
16f0fd9 
…est session! in other examples
@sdleffler
Simplify interface and reduce possibility of forgetting elimination pass
86c2053
@sdleffler
Fix serious error in handling nested blocks
b57b02d
@sdleffler
Simplify hello.rs example as now allowed by session! macro
2f140e2
@sdleffler
I like curly braces.
636bc28
@sdleffler
Rename session! macro to Session! because it's a type macro
ea866a9
@sdleffler
Propagate span info to get type errors to be shown correctly
6145d0f
@sdleffler
Fix test breakage from swapped Display output
ec2d7f4
@sdleffler
Add test for emitting Continue<S<Z>>
23ed617
@sdleffler
Fully convert tally.rs example to using the Session! type macro
b4c76f7
@sdleffler
Retype from u8 to usize to avoid potential overflows
a85d4dd
@sdleffler
Ensure tests do not rely on rustfmt's good favor
7f7177d
@plaidfinch @sdleffler
Implement the Then trait to support the macro compiler
aab22b4 
Fixes #32. This also eliminates unnecessary bounds left over from
previous iterations of the type system.
@plaidfinch @sdleffler
Fix up code generation for Then
c7931c0 
This matches the macro's code generation to the new `Then` trait.
@sdleffler
Fully qualified type codegen
e821b1f
@sdleffler sdleffler mentioned this pull request Mar 2, 2021
Closed
6 tasks
@sdleffler sdleffler linked an issue Mar 2, 2021 that may be closed by this pull request
Tracking issue for macro compiler #48
Closed
6 tasks
sdleffler and others added 15 commits March 3, 2021 10:47
@sdleffler
More internal documentation for cfg.rs, flow.rs, and target.rs.
bf6a681
@sdleffler
Checkpoint: allow optional terminators in blocks
4a1cf2a
@sdleffler
Allow terminators to be optional for specific statements
33a45d5
@sdleffler
Add loop_de_loop test
162c5d8
@sdleffler
Fix readme.py and add README/docs for dialectic-compiler
5adf068
@sdleffler
Fix dialectic-compiler crate docs
9506744
@sdleffler
Mention that dialectic-compiler is semver-exempt in its readme
e7483a7
@sdleffler
ToTokens for Spanned<Syntax>
5584f73
@sdleffler
First pass at parser roundtrip randomized test
cf3f6c1
@sdleffler
Allow optional syntax to be randomly added/removed during parser roun…
2908bb0 
…dtrip testing
@sdleffler
Refactor and add some comments to the quickcheck machinery for Spanne…
40028c7 
…d<Syntax>, and fix crate metadata
@sdleffler
Fix dialectic-macro crate manifest
c331311
@sdleffler
Move parser_roundtrip test out of syntax.rs into its own integration …
a4411b2 
…test
@sdleffler
Refactor Split nodes in Ir/Syntax to make which side is tx/rx explicit
b3b54b1
@sdleffler
Refactor readme.py to reannotate ignored tests for GitHub and also re…
4ad39a4 
…move critical functionality from being methods on Spanned
@plaidfinch plaidfinch merged commit 0cf758d into main Mar 5, 2021
@plaidfinch plaidfinch deleted the macro-compiler-dev branch March 5, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdleffler sdleffler sdleffler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for macro compiler
2 participants
@plaidfinch @sdleffler