Binary exported by workspace package causes "bolt install" failure

[bengummer]

Title	Description
Version	0.19.2
Type	Issue
node	8.9.4
Operating System	macOS 10.13.2
Short Description	Binary exported by workspace package causes "bolt install" failure
Detailed description	If I have a bolt workspace containing a package that has a "bin" entry in its package.json file, and also have another package in the same workspace that depends on the first bin-exporting package, then running bolt results in an error.

The error displayed is:

$ bolt
⚡️   bolt v0.19.2 (node v8.9.4)
🔎   [1/3] Validating project...
📦   [2/3] Installing project dependencies...
yarn install v1.3.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
✨  Done in 0.14s.
🔗   [3/3] Linking workspace dependencies...
error my-bin is linked to a location outside of project node_modules: ../../packages/my-bin/index.js

Demo repo here: https://github.com/bengummer/bolt-binary-issue-demo

yarn install works in the demo repo, bolt install doesn't

[lukebatchelor]

Ah. Thats interesting. We probably need to either symlink workspace's bins to the project bin, then dependents symlink to that, or modify this check to not happen with internal deps.

Probably option 2

[d4rkr00t]

Hm, it works fine here: https://bitbucket.org/atlassian/atlaskit-mk-2/src/394ebda17e5de5bd3eeb39d0574380fe283a9248/build/webpack-config/package.json#package.json-4 and https://bitbucket.org/atlassian/atlaskit-mk-2/src/394ebda17e5de5bd3eeb39d0574380fe283a9248/website/package.json#package.json-58

[bengummer]

Yeah the following tests looks like they test internal dependencies so i'm not sure why my demo repo has the issue.

https://github.com/boltpkg/bolt/blob/41e1ed61b2/src/utils/__tests__/symlinkPackageDependencies.test.js#L104

[jamiehodge]

I ran into this issue as well

[jamiebuilds]

Moving to #157