resolving cli flags to commands #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
reviewed
Jan 30, 2018
src/functions/flagHelper.js
Outdated
| @@ -0,0 +1,47 @@ | |||
| // @flow | |||
There was a problem hiding this comment.
This shouldn't be in src/functions
ajaymathur
force-pushed
the
amathur/support-flag-bolt
branch
from
cc60fb4
to
0846073
Compare
ajaymathur
force-pushed
the
amathur/support-flag-bolt
branch
from
0846073
to
e95b1f3
Compare
ajaymathur
changed the title
ajaymathur
force-pushed
the
amathur/support-flag-bolt
branch
from
cf78377
to
6ffcdb6
Compare
|
@jamiebuilds @lukebatchelor request review. 🙂 |
| // @flow | ||
| import * as options from './options'; | ||
|
|
||
| const BOOLEAN_FLAGS = { |
There was a problem hiding this comment.
I thought we discussed this before, that we couldnt have a hard coded list of boolean flags, because it's context dependent?
|
The approach taken here is not going to work:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passing flags to command. Fix : #90
Need Review. 🙂