Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bolt add, bolt workspace add and refactors bolt install #36

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

lukebatchelor
Copy link
Member

I uh.... Had some rebasing issues so I moved this PR here...

This is encompasses all the work from #27

  • adds yarn.add helper
  • adds symlinking helper
  • refactors install to use symlinking
  • adds tests for install

Its still a bit messy and theres some dupliacted code I'd like to clean up, but I wanna try to get this in and do any more refactors in the next drop (which would also add bolt workspaces add).

As an aside, the testing patterns I've been using have changed a fair bit over the course of all this, so I definitely want to refactor and align all that at some point.

The mock yarn.add command for instance is in three different forms in three different places. A single one that everything uses would be awesome.

@jamiebuilds jamiebuilds merged commit 13c8acb into master Oct 9, 2017
@jamiebuilds jamiebuilds deleted the lbatch/bolt-add-again branch October 9, 2017 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants