Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

remove error messages, enable rapid shutdown #1

Merged
merged 1 commit into from May 21, 2015

Conversation

jbarratt
Copy link
Contributor

When using your (very handy) container, I noticed

  • it was spitting out some error messages when starting up, as it was attempting to run 443 and 80 as commands
  • it was taking 10 seconds to docker stop the container, because the wrapper shell script (was wrapping another shell script that was wrapping another shell script) so the SIGTERM sent by docker stop was not getting to nginx.

This PR addresses both of those issues.

CMD ["sh", "configure_nginx.sh"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the square brackets form means it doesn't run sh -c "sh configure_nginx.sh", it just runs sh configure_nginx.sh.

@cbachich
Copy link
Member

Thanks Joshua! These are some good improvements. I'll merge them. I'm also going to take this opportunity to add automated builds for this project. I'll update the README and you can check it at: https://registry.hub.docker.com/u/cbachich/docker-ssl-proxy/

cbachich added a commit that referenced this pull request May 21, 2015
remove error messages, enable rapid shutdown
@cbachich cbachich merged commit 3b9e8a7 into bombbomb:master May 21, 2015
@jbarratt
Copy link
Contributor Author

That's fantastic, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants