Don't pass buffer as format string and free buffer

Fixes warning "format string is not a string literal (potentially insecure)" and a memory leak.
bombela · May 31, 2021 · c9f2b47 · c9f2b47
1 parent 7794605
commit c9f2b47
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/backward.hpp b/backward.hpp
@@ -3637,13 +3637,14 @@ template <> class TraceResolverImpl<system_tag::windows_tag>
       char* lpMsgBuf;
       DWORD dw = GetLastError();
 
-      FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER |
-                        FORMAT_MESSAGE_FROM_SYSTEM |
-                        FORMAT_MESSAGE_IGNORE_INSERTS,
-                    NULL, dw, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
-                    (char*)&lpMsgBuf, 0, NULL);
-
-      printf(lpMsgBuf);
+      if (!FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER |
+                              FORMAT_MESSAGE_FROM_SYSTEM |
+                              FORMAT_MESSAGE_IGNORE_INSERTS,
+                          NULL, dw, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
+                          (char*)&lpMsgBuf, 0, NULL)) {
+      std::fprintf(stderr, "%s\n", lpMsgBuf);
+      LocalFree(lpMsgBuf);
+    }
 
       // abort();
     }