Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceResolverImpl<system_tag::windows_tag>::resolve marked override breaks MSVC build #208

Closed
taidg opened this issue Apr 22, 2021 · 1 comment
Closed

TraceResolverImpl<system_tag::windows_tag>::resolve marked override breaks MSVC build #208

taidg opened this issue Apr 22, 2021 · 1 comment

Comments

@taidg
Copy link

taidg commented Apr 22, 2021

TraceResolverImpl<system_tag::windows_tag> does not inherit from a base class, but as of #162 the resolve method is marked override, causing a compiler error.

Either the class should inherit from a base class or the recently added override should be removed.
@taidg taidg mentioned this issue Apr 22, 2021
Closed
@taidg
Copy link
Author

taidg commented Apr 22, 2021

Looks like removing it does not work, only adding the base class TraceResolverImplBase

@taidg taidg mentioned this issue Apr 22, 2021
Merged
bombela added a commit that referenced this issue Apr 23, 2021
@bombela
Merge pull request #210 from taidg/master
12b9ee3 
fix #208 Add TraceResolverImplBase as base class of TraceResolverImpl<system_tag::windows_tag>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ::resolve override added in #162 taidg/backward-cpp
1 participant
@taidg