Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken travis build - conan 'test_package' removed #90

Closed
hestad opened this issue Dec 27, 2017 · 4 comments
Closed

Broken travis build - conan 'test_package' removed #90

hestad opened this issue Dec 27, 2017 · 4 comments

Comments

@hestad
Copy link

hestad commented Dec 27, 2017

https://travis-ci.org/bombela/backward-cpp/jobs/319897290

conan test_package --build=outdated
ERROR: Unknown command 'test_package'

https://github.com/conan-io/conan/releases

Command test_package has been removed. Use conan create instead, and conan test for just running package tests.

Also on line 35 in the conanfile.py I think the new practice is to use CMake(self) instead of CMake(self.settings). Ref: https://github.com/conan-io/docs/blob/master/reference/build_helpers/cmake.rst

0.29.0: Deprecation: Removed old CMake helper methods (only valid constructor is CMake(self))

@bombela
Copy link
Owner

bombela commented Dec 27, 2017

pull request welcome ;)

@Manu343726
Copy link
Collaborator

Manu343726 commented Dec 28, 2017 via email

@Manu343726
Copy link
Collaborator

is there any chance that we review the PR that fixes this or I should directly merge the fix?

bombela added a commit that referenced this issue Jan 11, 2018
Update conan recipes to use the latest recipe APIs. Fixes #90
@hestad
Copy link
Author

hestad commented Jan 12, 2018

In which conan-repo will this end up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants