Find dependencies for statically-linked libdw #250
Merged
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackwardConfig.cmake was not explicitly pulling in the dependencies (libelf, libz, etc.) of libdw, which made it fail to link when libdw was built as a static library (and therefore didn't explicitly encode those dependencies).
csw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackwardConfig.cmake was not explicitly pulling in the dependencies of libdw (libelf, libz, libpthread, etc.), which made it fail to link when libdw was built as a static library (and therefore didn't explicitly encode those dependencies). This fixes that. For context, I'm trying to make it work with vcpkg, using its version of elfutils. (I'm working on adding a vcpkg port for this library, too.)
I had logic in here to use pkg-config, but doing it that way made it use the system version of libdw instead of the one in vcpkg.