Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: %lu printf code can't be used for size_t types on 32 bit #6

Closed
wants to merge 1 commit into from

Conversation

redbaron
Copy link

@redbaron redbaron commented Apr 5, 2013

C++ can't use %zu code which is standard for C99 and above, so I added CPP ifdefs to fix that printf

Change-Id: I4d6f17f326852ba691599f285b17f79ebcaec761
@bombela
Copy link
Owner

bombela commented Apr 5, 2013

Damned me, I forgot to adjust all the size_t to unsigned. An unsigned can represent 4 billions of lines. I do make an assumption saying it is enough :P

Thus it's easier/more portable to simply rename all size_t used to represent lines to unsigned, because the printf argument will be valid by definition. Please tell me if you want to do it, or you prefer that I take care of it.

Thanks for contributing!

Best,
fx

@redbaron
Copy link
Author

redbaron commented Apr 6, 2013

nah, I'll leave it to you ;)

@ghost ghost assigned bombela Apr 12, 2013
@bombela
Copy link
Owner

bombela commented Jun 25, 2013

Thanks to Kobolog for fixing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants