Fix compilation on gcc-4.1 #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombela
reviewed
Oct 4, 2017
| @@ -1590,7 +1590,7 @@ class SourceFile { | |||
| swap(from); return *this; | |||
| } | |||
| #else | |||
| explicit SourceFile(const SourceFile& from) { | |||
There was a problem hiding this comment.
This is not a good idea. It will allow implicit move semantic. Which is going to corrupt the from argument silently. Forcing it explicit ensures that you somewhat know what you are doing. A solution is maybe to make both the move constructor and the poor's man move constructor private. And then write move methods wrapping them. Which is by definition explicit to call.
move(const SourceFiles* from) on <C++11
and for >=C++11
move(SourceFile&& from)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old but long-lasting system (like those installed on supercomputers) use pretty old compilers. So make backward work on gcc-4.1 is useful. This PR fixes it. It is tested on docker uilianries/conangcc41 and both the compilation and the stacktrace printing works.